Skip to content

conformance: Rename infra namespace #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

conformance: Rename infra namespace #1667

wants to merge 1 commit into from
+56 −57

Conversation

davidjumani
Copy link

What type of PR is this?

Add one of the following kinds:
/kind cleanup

Optionally add one or more of the following kinds if applicable:
/area conformance-test

What this PR does / why we need it:
This renames the inference conformance infra from gateway-conformance-infra to inference-conformance-infra.
This allows clean back-to-back runs of the Gateway API and Inference Extension conformance tests avoiding any failures caused by using the same namespace

Which issue(s) this PR fixes:

Fixes #1315

Does this PR introduce a user-facing change?:

Rename the conformance infra namespace to `inference-conformance-infra`

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

@davidjumani: The label(s) area/conformance-test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Add one of the following kinds:
/kind cleanup

Optionally add one or more of the following kinds if applicable:
/area conformance-test

What this PR does / why we need it:
This renames the inference conformance infra from gateway-conformance-infra to inference-conformance-infra.
This allows clean back-to-back runs of the Gateway API and Inference Extension conformance tests avoiding any failures caused by using the same namespace

Which issue(s) this PR fixes:

Fixes #1315

Does this PR introduce a user-facing change?:

Rename the conformance infra namespace to `inference-conformance-infra`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidjumani
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit b3ca305
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68dbe653b4a20d00071517e2
😎 Deploy Preview https://deploy-preview-1667--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 30, 2025
@davidjumani davidjumani marked this pull request as draft September 30, 2025 14:24
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@davidjumani davidjumani marked this pull request as ready for review September 30, 2025 15:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@danehans
Copy link
Contributor

danehans commented Oct 1, 2025

@davidjumani did you run the conformance test suite after making these changes? If not, you can follow these steps and instead of calling make gie-conformance, run the conformance suite from your gateway-api-inference-extension fork:

$ go test -v ./conformance -args -debug=true -gateway-class=kgateway

@davidjumani
Copy link
Author

davidjumani commented Oct 2, 2025 •
edited
Loading

@davidjumani did you run the conformance test suite after making these changes? If not, you can follow these steps and instead of calling make gie-conformance, run the conformance suite from your gateway-api-inference-extension fork:

I initially verified the change via the make command. Running it again and all passed

--- PASS: TestConformance (51.20s)
    --- PASS: TestConformance/EppUnAvailableFailOpen (1.29s)
        --- PASS: TestConformance/EppUnAvailableFailOpen/Phase_1:_Verify_baseline_connectivity_with_EPP_available (0.18s)
        --- PASS: TestConformance/EppUnAvailableFailOpen/Phase_2:_Verify_fail-open_behavior_after_EPP_becomes_unavailable (0.08s)
    --- PASS: TestConformance/GatewayFollowingEPPRouting (18.09s)
        --- PASS: TestConformance/GatewayFollowingEPPRouting/should_route_traffic_to_a_single_designated_pod (0.20s)
        --- PASS: TestConformance/GatewayFollowingEPPRouting/should_route_traffic_to_two_designated_pods (0.19s)
        --- PASS: TestConformance/GatewayFollowingEPPRouting/should_route_traffic_to_all_available_pods (0.20s)
    --- PASS: TestConformance/HTTPRouteInvalidInferencePoolRef (1.03s)
        --- PASS: TestConformance/HTTPRouteInvalidInferencePoolRef/HTTPRoute_should_have_Accepted=True_and_ResolvedRefs=False_for_non-existent_InferencePool (1.01s)
    --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools (1.30s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/Primary_HTTPRoute,_InferencePool,_and_Gateway_path:_verify_status_and_traffic (1.15s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/Secondary_HTTPRoute,_InferencePool,_and_Gateway_path:_verify_status_and_traffic (0.11s)
    --- PASS: TestConformance/InferencePoolAccepted (0.04s)
        --- PASS: TestConformance/InferencePoolAccepted/InferencePool_should_have_Accepted_condition_set_to_True (0.00s)
    --- PASS: TestConformance/InferencePoolHTTPRoutePortValidation (0.25s)
        --- PASS: TestConformance/InferencePoolHTTPRoutePortValidation/Scenario_1:_HTTPRoute_backendRef_to_InferencePool_with_Port_Unspecified (0.11s)
        --- PASS: TestConformance/InferencePoolHTTPRoutePortValidation/Scenario_2:_HTTPRoute_backendRef_to_InferencePool_with_Port_Specified_and_Matching (0.05s)
        --- PASS: TestConformance/InferencePoolHTTPRoutePortValidation/Scenario_3:_HTTPRoute_backendRef_to_InferencePool_with_Port_Specified_and_Non-Matching._Request_still_passing_because_HTTP_Port_is_ignored_when_inferencePool_is_backendRef (0.04s)
    --- PASS: TestConformance/InferencePoolInvalidEPPService (1.05s)
        --- PASS: TestConformance/InferencePoolInvalidEPPService/InferecePool_has_a_ResolvedRefs_Condition_with_status_False (0.00s)
        --- PASS: TestConformance/InferencePoolInvalidEPPService/Request_to_a_route_with_an_invalid_backend_reference_receives_a_500_response (0.01s)
    --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools (1.27s)
        --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools/Wait_for_resources_to_be_accepted (1.02s)
        --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools/Traffic_should_be_routed_to_the_correct_pool_based_on_path (0.22s)
            --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools/Traffic_should_be_routed_to_the_correct_pool_based_on_path/request_to_primary_pool (0.12s)
            --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools/Traffic_should_be_routed_to_the_correct_pool_based_on_path/request_to_secondary_pool (0.10s)
    --- PASS: TestConformance/InferencePoolResolvedRefsCondition (11.37s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/InferencePool_should_show_Accepted:True_by_parents_and_be_routable_via_multiple_HTTPRoutes (0.23s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-primary-gw_and_verify_InferencePool_status_and_routing_via_secondary_gw (5.07s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-secondary-gw_and_verify_InferencePool_has_no_parent_statuses_and_is_not_routable (5.02s)
PASS
ok  	sigs.k8s.io/gateway-api-inference-extension/conformance	51.729s

Some logs to indicate that the ns has indeed changed

    apply.go:275: 2025-10-02T09:30:28.653364-04:00: Creating inference-conformance-infra Namespace
    apply.go:275: 2025-10-02T09:30:28.659052-04:00: Creating inference-conformance-app-backend Namespace
    conformance.go:265: Attempting to fetch Gateway inference-conformance-infra/conformance-primary.
    conformance.go:265: Shared Gateway inference-conformance-infra/conformance-primary is ready.

@danehans
Copy link
Contributor

danehans commented Oct 6, 2025

cc: @robscott @zetxqx for reviews

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

@robscott robscott Awaiting requested review from robscott

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@danehans danehans

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conformance: Rename Infra Namespace
3 participants
@davidjumani @k8s-ci-robot @danehans